Skip to content

Fix rabbitmq testLatestDeps #15048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2025
Merged

Fix rabbitmq testLatestDeps #15048

merged 4 commits into from
Oct 20, 2025

Conversation

@jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Oct 18, 2025 •
edited by laurit
Loading

Resolves #15044
Resolves #15046

maybe there's a clever way to fix this, but it looks like in the process of deprecating NIO (rabbitmq/rabbitmq-java-client#1664) they removed void com.rabbitmq.client.ConnectionFactory.useNio() but that is still called by reactor-rabbitmq.

I opted for skipping just this one test instead of setting latestDepTestLibrary to 5.26 because the other tests are still working

the error was:

java.lang.NoSuchMethodError: 'void com.rabbitmq.client.ConnectionFactory.useNio()'
    at reactor.rabbitmq.SenderOptions.lambda$new$0(SenderOptions.java:39)
    at reactor.rabbitmq.SenderOptions.<init>(SenderOptions.java:41)
    at io.opentelemetry.javaagent.instrumentation.rabbitmq.ReactorRabbitMqTest.testShouldNotFailDeclaringExchange(ReactorRabbitMqTest.java:34)
    at java.base/java.lang.reflect.Method.invoke(Method.java:580)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
    at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

@jaydeluca jaydeluca requested a review from a team as a code owner October 18, 2025 19:59
jaydeluca
jaydeluca commented Oct 18, 2025
View reviewed changes
...t/src/test/java/io/opentelemetry/javaagent/instrumentation/rabbitmq/ReactorRabbitMqTest.java
sender.declareExchange(ExchangeSpecification.exchange("testExchange")).block();
} catch (RuntimeException e) {
Assertions.fail("Should not fail declaring exchange", e);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes to the test itself are just cleanups and refactoring to use our more standard approach of assertions

@laurit laurit enabled auto-merge (squash) October 20, 2025 10:40
@laurit laurit merged commit 5eb8527 into open-telemetry:main Oct 20, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Workflow failed: Build (daily --no-build-cache) (#1309) Workflow failed: Build (daily) (#1313)

2 participants

@jaydeluca @laurit